theopensystemslab / planx-new

Planβœ• is a platform for creating and publishing digital planning services
https://editor.planx.uk
Mozilla Public License 2.0
13 stars 2 forks source link

refactor: remove `submission_email` column from `teams` table #3640

Closed RODO94 closed 1 week ago

RODO94 commented 1 week ago

What does this PR do?

To finish the work on https://trello.com/c/dVsTQpZZ/2984-allow-editors-to-see-update-their-teams-submission-email-in-team-settings-form

I have dropped the redundant column and adjusted the scripts which create the local DBs.

In order to keep the team_summary table, I had to adjust the sql code which creates it. From here I also repointed the homepage column of this table from teams table to team_settings table.

Up script running order:

  1. Change team_summary view using team_settings.submission_email column
  2. Remove teams.submission_email column

Down script:

  1. Add teams.submission_email column
  2. Replace team_summary view using new column

Regression tests passing

github-actions[bot] commented 1 week ago

πŸ€– Hasura Change Summary compared a subset of table metadata including permissions:

Updated Tables (1)

github-actions[bot] commented 1 week ago

Removed vultr server and associated DNS entries

RODO94 commented 1 week ago

Allow editors to see/update their team's submission email in "Team settings" form