chore: `MapAndLabel` tidy ups - Githubissues

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services

https://editor.planx.uk

Mozilla Public License 2.0

13 stars 2 forks source link

chore: `MapAndLabel` tidy ups #3643

Closed jessicamcinchak closed 1 week ago

jessicamcinchak commented 1 week ago

A few tidy ups & fixes now that all major functionality is merged & open for testing ! Follows on from #3625

Fixes here:

[x] Tabs correctly sorted - previous bug where 10 was getting sorted before 2 because geojson properties require labels to be stored as strings, but we want to sort them as numbers
[x] activeTabIndex more consistently managed based on length of features when adding & removing features
[x] After removing a feature, make zoom / map viewport repositioning less jumpy

Known still-outstanding bugs, to address in followup PRs:

When modifying a feature on the map, set corresponding tab as active index (modified feature will be last item in features array)
When coming "back"/"changing", ensure latest tab is set as active one & all tabs are edit-able
When coming "back"/"changing", ensure features can be added/removed in addition to editing existing features

github-actions[bot] commented 1 week ago

Removed vultr server and associated DNS entries