Closed RODO94 closed 2 days ago
π€ Hasura Change Summary compared a subset of table metadata including permissions:
public.users
permissions:
insert | select | update | delete | |
---|---|---|---|---|
platformAdmin | β/β |
insert | select | update | |
---|---|---|---|
platformAdmin | β first_name β last_name |
Removed vultr server and associated DNS entries
@DafyddLlyr picking up the refactors now around this, thanks for the pointers! Will keep things D.R.Y...
LOVE seeing some mermaid in the PR explanation!! π§ββοΈ
What does this PR do?
This PR deals with the Trello ticket: https://trello.com/c/7MAKUC2N/3011-edit-user-in-editor
And follows on from work done in this ticket: https://trello.com/c/piMcGsJa/2973-add-user-in-editor
I am adding an edit feature to the Team Members area, where a platformAdmin can update the first name, last name, and email of a user.
The work has used things built on for adding a user, and changes the relevant modal component from
AddTeamEditorModal
toEditorUpsertModal
relying on the update/insert portmanteau.I have also added a Permissions check at the
edit
button component level, incase we want more nuanced permissions in the future.Test Coverage:
After chatting to @jamdelion about it, we said there's probably Modal specific tests here which are not contextually linked to editing user, and more about how the modal operates. Scope to add this to a Modal specific test file which would make more sense if we were to reuse the component for other things like Adding a Team, or Adding a Flow in future.