chore: extend `SiteAddress` type to account for ranges - Githubissues

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services

https://editor.planx.uk

Mozilla Public License 2.0

14 stars 2 forks source link

chore: extend `SiteAddress` type to account for ranges #3670

Closed jessicamcinchak closed 1 month ago

jessicamcinchak commented 1 month ago

It came up in Idox feedback that we aren't currently supporting address ranges in the ODP Schema. I looked through the OneApp JSON example we have and don't see any instances of it handling ranges either, but nonetheless it's low effort for us to start more carefully checking for these.

So, this PR adds a few extra fields from the OS Places API "LPI" data source to our internal model which we can later decide how to send along in payloads / the ODP Schema (https://github.com/theopensystemslab/digital-planning-data-schemas/pull/236).

Only additive changes here!

saoEnd
paoEnd
ward
parish

Links:

OS Docs (ctrl + f "LPI Output"): https://osdatahub.os.uk/docs/places/technicalSpecification
Example response: https://api.editor.planx.dev/proxy/ordnance-survey/search/places/v1/postcode?postcode=SE5+0HU&dataset=LPI&maxResults=100&output_srs=EPSG%3A4326&lr=EN&offset=0

github-actions[bot] commented 1 month ago

Removed vultr server and associated DNS entries