fix: Add flow.settings back to public queries

DafyddLlyr commented 5 days ago

What's the problem?

Flow settings aren't being fetched when loading public views. This means that the full list of footer items is not displayed and invalid URLs are generated.
Regression introduced here when trying to remove team.settings - https://github.com/theopensystemslab/planx-new/pull/3391/files#diff-008018675f9c3d6c1c855a2715fc884f7ac3a9eea5a5c5539244910fc6a9995d (a while ago!)

Before (staging) - https://editor.planx.dev/buckinghamshire/apply-for-a-lawful-development-certificate/published?analytics=false

After (pizza) - https://3673.planx.pizza/buckinghamshire/apply-for-a-lawful-development-certificate/published?analytics=false

github-actions[bot] commented 5 days ago

Removed vultr server and associated DNS entries

DafyddLlyr commented 3 days ago

@jessicamcinchak Yep had this same thought! Quite a bad oversight on our part and really only properly testable in an E2E environment (mocks would have failed here also more likely than not).

theopensystemslab / planx-new

fix: Add flow.settings back to public queries #3673

What's the problem?