search

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services
https://editor.planx.uk
Mozilla Public License 2.0
14 stars 2 forks source link

feat: SummaryList view of Page component #3679

Closed DafyddLlyr closed 1 month ago

DafyddLlyr commented 1 month ago

What does this PR do?

Adds a view of the Page component inside SummaryList (Review component)

image

Would love some thoughts here @ianjon3s - very much not sold on this UI.

Breaking this out into its own dl seems like the better solution here, but that would require a bit of a wider refactor due to how we're currently inserting components into cells. So I'm offering this up as a very rough version which at least handles getting the data to the right place, and to open up the discussion on the user interface

github-actions[bot] commented 1 month ago

Removed vultr server and associated DNS entries

ianjon3s commented 1 month ago

I agree @DafyddLlyr, not ideal visually, and tricky as you say with the setup of injecting data into a pre-defined layout.

However it does communicate the information in a way that is clear about the structure of the questions, and collapses to a single column correctly on smaller screens, so is more than adequate at this point.