fix: Move "invalid graph" warning to `MapFieldInput`

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services

https://editor.planx.uk

Mozilla Public License 2.0

13 stars 2 forks source link

fix: Move "invalid graph" warning to `MapFieldInput` #3689

Closed DafyddLlyr closed 1 day ago

DafyddLlyr commented 2 days ago

What?

Moves the "invalid graph" warning from a high level component, to the lower level MapFieldInput

Why?

I noticed when working on 11aa28a that I also needed to handle this error in the Page component. The actual component responsible for this dependency is the MapFieldInput, so it makes sense to do the error handling here once as opposed to remembering to do it in each parent which renders this component.

github-actions[bot] commented 2 days ago

Removed vultr server and associated DNS entries

DafyddLlyr commented 1 day ago

@RODO94 @jessicamcinchak Thanks both for the feedback, please see recent commits which make the following changes -

Use the ErrorBoundary mechanism to throw and catch a new type of error - GraphError
This does not log to Airbrake
This maintains the same visual style as currently used by the invalid graph warnings
Ensures there's only a single place where the graph error component is defined