fix: Flow URLs should re-compute on re-render of Sidebar - Githubissues

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services

https://editor.planx.uk

Mozilla Public License 2.0

13 stars 2 forks source link

fix: Flow URLs should re-compute on re-render of Sidebar #3692

Closed DafyddLlyr closed 2 days ago

DafyddLlyr commented 2 days ago

What's the problem?

Bug introduced in https://github.com/theopensystemslab/planx-new/pull/3668
URLs are not being re-generated when the route changes
This is because by defining urls outside of the lifecycle scope of a component, this is never re-generated
To recreate -
- Navigate to a flow in the Editor, checkout icon hrefs in Sidebar
- Navigate to another flow
- Icon hrefs have not updated ❌

What's the solution?

Calculate within the Sidebar component
Pass URL as prop, instead of importing it

github-actions[bot] commented 2 days ago

Removed vultr server and associated DNS entries