It's the second planning meeting in a row where Ian G has asked about / been a bit confused by adding and editing users and I think it's because he can see the add button as a teamEditor, but doesn't have permission to actually use it.
This change hides the "Add a new editor" from non-platformAdmins similar to the "Edit" button. Database-level permissions already look correct (eg only platformAdmin role has "insert" permission on team_members table).
github-actions[bot]
commented
10 hours ago
It's the second planning meeting in a row where Ian G has asked about / been a bit confused by adding and editing users and I think it's because he can see the add button as a
teamEditor, but doesn't have permission to actually use it.This change hides the "Add a new editor" from non-
platformAdminssimilar to the "Edit" button. Database-level permissions already look correct (eg onlyplatformAdminrole has "insert" permission onteam_memberstable).We've thrown this previous error: https://opensystemslab.slack.com/archives/C01E3AC0C03/p1725542317058179
Good reminder to ourselves to trigger our own
platformAdminstatus "off" sometimes when testing/code reviewing pizzas!