fix: Handle dynamic import error - Githubissues

theopensystemslab / planx-new

Plan✕ is a platform for creating and publishing digital planning services

https://editor.planx.uk

Mozilla Public License 2.0

14 stars 2 forks source link

fix: Handle dynamic import error #3788

Closed DafyddLlyr closed 1 month ago

DafyddLlyr commented 1 month ago

What's the problem?

After the app re-build and redeploys, assets are renamed (chunked .js files generated by pnpm build)
If a user is already using the app and needs a chunk which is no longer available post-deploy, this error is thrown
Fixes https://planx.airbrake.io/projects/329753/groups/3879282825748388260?tab=overview
We also faced a similar error pre-Vite which looked like this - ChunkLoadError: Loading chunk 914 failed.

What's the solution?

Catch the error and reload the page in order to access the required chunks
I've seen some apps handle this more gracefully with a "Site is outdated, fetching new assets..." error - maybe we should consider something like this? Right now I think deploys are infrequent enough we can probably get away with a refresh. Thoughts welcome!
Docs - https://vite.dev/guide/build#load-error-handling

github-actions[bot] commented 1 month ago

Removed vultr server and associated DNS entries