search

theophanemayaud / video-simili-duplicate-cleaner

https://theophanemayaud.github.io/video-simili-duplicate-cleaner/
GNU General Public License v3.0
51 stars 5 forks source link

Selecting cancel during "Set custom cache location" results in a null cache location #100

Closed newadventure079 closed 1 year ago

newadventure079 commented 1 year ago

Steps to reproduce:

  1. Select Tools -> Set custom cache location
  2. On the File browser dialog that is opened, just press cancel

Result: App console now says Cache now used:

I'm guessing the cache location is now null but I'm not sure

If cancel is chosen, nothing should happen/change

theophanemayaud commented 1 year ago

Oh great catch thanks !!! I’ll check out what it’s actually doing and fix this like you suggested with a proper message.

newadventure079 commented 1 year ago

Also, leaving the Folders to search text input box blank, should produce an error saying to enter folders that you want searched.

Right now, if nothing is entered into that field it tries to search nothing

Searching for videos...

Found 0 video file(s):
theophanemayaud commented 1 year ago

So indeed, when canceling it was simply setting the path to the cache as null, resulting in the cache being placed in the root of your system ! Thanks a lot, I've fixed if with commit 791b24cf67123061798a1793059a93f93cf492c5