search

theopolis / uefi-firmware-parser

Parse BIOS/Intel ME/UEFI firmware related structures: Volumes, FileSystems, Files, etc
Other
780 stars 156 forks source link

File-not-exist failures are not evident #98

Closed MikeSpreitzer closed 2 years ago

MikeSpreitzer commented 3 years ago

As can be seen at https://github.com/theopolis/uefi-firmware-parser/blob/2af7e41c800300b0509494cec1db7125d2be2de9/bin/uefi-firmware-parser#L142 , in case a given file does not exist, the program does not terminate a non-zero exit code. That makes it tough to use carefully from a higher level shell script or program.

theopolis commented 3 years ago

Good find, do you mind submitting a PR with a fix?