theorchard / monolog-cascade

Configure multiple loggers and handlers in the blink of an eye
MIT License
145 stars 62 forks source link

Add LoggerLoader + Cascade Config class + Monologger #13

Closed rantonmattei closed 9 years ago

rantonmattei commented 9 years ago

I had to group those 3 cause MonoLogger uses the config class and the LoggerLoader instantiates the Logger object using MonoLogger::getLogger()

So, here is what this does:

@mortaliorchard @OrCharles

That's all folks! (in term of code...)

mortaliorchard commented 9 years ago

Overall LGTM. R+ (one question, but it's not blocking.)

OrCharles commented 9 years ago

would be curious to know the answer to the registry clearing question posed by Michael above...

R+

rantonmattei commented 9 years ago

I need to refactor the Monologger class a bit cause I realized there is no need to extend the \Monolog\Logger class. I'm going to get rid of the constructor and write a factory method instead. It would check the registry to see if the named logger is there and if not will instantiate a \Monolog\Logger object and push it to the registry. I'm thinking of renaming that class too. Maybe just Logging so the full namespace would be \Cascade\Logging. Thanks for the review guys