search

theorchard / monolog-cascade

Configure multiple loggers and handlers in the blink of an eye
MIT License
145 stars 62 forks source link

Added aliases for Cascade::fileConfig plus a bunch of minor fixes #71

Closed cheeZery closed 7 years ago

cheeZery commented 7 years ago

Now I finally came through to add that missing array param for the fileConfig method myself, as we discussed in issue #70. While I was at it I also added two aliases for Cascade::fileConfig. I know, it's not perfect, but maybe it will do. Feel free to suggest any changes and I will implement them! :-) I also fixed a lot of minor bugs, mainly in the phpdocs, maybe I've overdone a bit.. But most of the work did PhpStorm by itself to be completely honest.

This is also my first PR on Github so I hope I didn't made any bigger mistakes.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8809024025846294ffe20862d82aebf3b2b69335 on cheeZery:carstendietzel-phpdoc-fixes-and-aliases into c67e060d1e528d3b52165a84b60b30ad7e380e9a on theorchard:master.

jessmchung commented 7 years ago

@cheeZery Can you split this into two PRs- one with just the phpdoc fixes, and the other with the aliases? Tag me on them after. Thanks!

jessmchung commented 7 years ago

Closing bc of #74 and #75.