Closed llaville closed 5 years ago
ping no feedback or comments since 2 weeks.
Hello @llaville, thanks for bringing this issue. I'd rather not having to maintain multiple versions of PhpUnit in the code because it would open the door to many requests depending on each person's versions of Php, packages, etc. Loose versioning seems more appropriate.
Looks to me that replacing instances of getMock('[classname]')
with getMockBuilder('[classname]')->getMock()
does the trick.
E.g. in practice:
$fileLocatorMock = $this->getMock(
'Symfony\Component\Config\FileLocatorInterface'
);
would become
$fileLocatorMock = $this->getMockBuilder(
'Symfony\Component\Config\FileLocatorInterface'
)->getMock();
As a result, we'll also need to bump up the version of phpunit/phpcov
to ^3.1
which looks fine to me.
Unfortunately, although it is a quick task, I do not have the bandwidth to tackle this at the moment feel free to update your PR or submit a new one.
Cheers! Raf
PS: FYI @jessmchung ^^^ let me know if you have some input on this.
Hello,
Because the PHPUnit version 4.8 is no longer supported, we could think to raise dependencies higher or just make the code compatible.
I'll propose you the second option, with two commits :
Awaiting your feedback.
Currently code without my PR, with PHP 5.6.31 and PHPUnit 5.7 output such results :
With my PR, with PHP 5.6.31 and PHPUnit 4.8 give
And of course with PHP 5.6.31 and PHPUnit 5.7