search

theory / svn-notify

Subversion activity notification
http://search.cpan.org/dist/SVN-Notify/
18 stars 18 forks source link

Change from Email::Address, which is marked as deprecated, to the com… #19

Closed mpghf closed 6 years ago

mpghf commented 6 years ago

Change from Email::Address, which is marked as deprecated, to the compatible Email::Address::XS. https://github.com/Perl-Email-Project/Email-Address/commit/fcc869adf7a22d92bfc13283950b5604c532b3fe

theory commented 6 years ago

Bah, broke the build. Please update the Build.PL file, too.

mpghf commented 6 years ago

New pull request created for Build.PL. Sorry for the breakage - I'm not much of a perl module expert.

theory commented 6 years ago

Would one of you like to take over maintenance of this fine module?

pali commented 6 years ago

Sorry, but I do not have time for maintaining another module :-(

mpghf commented 6 years ago

I'd be happy to, but to be honest, I don't know if I'm qualified with the meagre Perl skills and virtually zero Perl module knowledge that I have.

If you're willing to put up with some questions, mainly regarding building and testing modules, I'd be keen to give it a shot though.

theory commented 6 years ago

I'm happy to answer questions. Feel free to email me.

mpghf commented 6 years ago

Thanks. I'll be in contact.

gregoa commented 6 years ago

With this patch applied, the test suite throws tons of Argument contains empty address at /build/libsvn-notify-perl-2.86/blib/lib/SVN/Notify.pm line 1476.warnings. This doesn't look right to me ...

Full log at https://bugs.debian.org/887549

mpghf commented 6 years ago

That's unfortunate. I'll look into this.

mpghf commented 6 years ago

I've created pull request #22 to fix this the issue mentioned by gregoa above.