search

theory / svn-notify

Subversion activity notification
http://search.cpan.org/dist/SVN-Notify/
18 stars 18 forks source link

Support SMTP over SSL #4

Open skoehler opened 12 years ago

skoehler commented 12 years ago

Hi,

there are three modes for SMTP: 1) unencrypted connection (typically via port 25, multiple auth methods available: plain, md5, etc.) 2) SMTP+TLS (typically via port 25, intially communication is unencrypted, but then the client issues a STARTTLS command and if supported by the server, subsequent communication is encrypted) 3) SMTP over SSL (typically via port 465, all communication is encrypted, client and host perform SSL handshake before communicating)

I believe, at the moment only 1+2 are supported (via Net::SMTP::TLS). However, mode 3 is not supported (can be supported via Net::SMTP::SSL or Net::SMTP_auth::SSL).

Also, the --smtp-auth option has been deprecated, which is a shame IMHO. If the server does not support TLS/SSL one will typically like to enforce MD5 or something similar to avoid plain text authentication. I'm not sure how to influence the choices of auth mode choices by Net::SMTP::TLS. It would be better to use Net::SMTP::TLS if and only if the user requested tls. Otherwise, use Net::SMTP and Net::SMTP::SSL or even Net::SMTP_auth and Net::SMTP_auth::SSL depending on whether SSL was requested.

theory commented 12 years ago

If this is something you would like to work on and submit a pull request, that would be great. I don't really have the tuits right now, especially since i no longer use SVN::Notify myself.