theory / svn-notify

Subversion activity notification
http://search.cpan.org/dist/SVN-Notify/
18 stars 18 forks source link

Changed attached diff Content-Type to text/x-diff #5

Closed dpwright closed 12 years ago

dpwright commented 12 years ago

Some mail readers (such as mutt) rely on the Content-Type rather than the file extension in order to determine the type of an attachment. This commit sets attached diffs to use the far more descriptive text/x-diff content-type, rather than text/plain.

theory commented 12 years ago

I suspect that a lot of mail readers will not know what to do with that content-type. I think better would be to add an option to set the content type. Perhaps a --diff-content-type option?

dpwright commented 12 years ago

Makes sense -- I'll see if I can roll something up over the weekend.

Daniel P. Wright Sparrow (http://www.sparrowmailapp.com/?sig) を使って送信

日付:金曜日, 20 7月 2012、時刻:19:21、差出人:David E. Wheeler:

I suspect that a lot of mail readers will not know what to do with that content-type. I think better would be to add an option to set the content type. Perhaps a --diff-content-type option?


Reply to this email directly or view it on GitHub: https://github.com/theory/svn-notify/pull/5#issuecomment-7126919

dpwright commented 12 years ago

Which do you consider to be the better default -- the existing text/plain or text/x-diff as above?

theory commented 12 years ago

On Jul 20, 2012, at 2:02 PM, Daniel P. Wright wrote:

Which do you consider to be the better default -- the existing text/plain or text/x-diff as above?

The existing text/plain -- better for backward compatibility.

dpwright commented 12 years ago

I've added the --diff-content-type parameter; are the commits above acceptable?

theory commented 12 years ago

Yep, merged, thanks!