search

theory / svn-notify

Subversion activity notification
http://search.cpan.org/dist/SVN-Notify/
18 stars 18 forks source link

Headers are not escaped properly #6

Closed skoehler closed 11 years ago

skoehler commented 12 years ago

This issue exists at least for SVN::Notify 2.80, but I assume the issue is not fixed for later version as well.

The headers of the emails I receive look like this: From: "Sven Köhler" skoehler@users.sourceforge.net

Note, that the ö is not escaped. It is represented by its 8-Bit utf8 encoding. I believe, the same holds for the Subject as well, if it would contain an ö character.

Now here's what the headers should look like: To: =?ISO-8859-15?Q?Sven_K=F6hler?= skoehler@users.sourceforge.net Subject: =?ISO-8859-15?Q?k=E4se?=

Of course, one might use utf-8 instead of latin9 (ISO-8859-15). Actually, any sensible perl library for sending emails should take care of that automatically, once the input has been converted to proper perl utf8 strings. (By definition, any other library is not sensible).

I believe, 8-Bit characters in the headers are basically forbidden. In some cases, SMTP servers even redically replace any character >127 with an X, which would transform my name into something like "Sven KXXhler".

I haven't reviewed the source of SVN::Notify well enough to tell what is wrong. I'll post the details, when I reviewed the soure.

theory commented 12 years ago

Funny no one ever reported this before. Looks as though output_headers() should be doing some encoding, probably using Encode::MIME::Header.

skoehler commented 12 years ago

I should mention, that this about SourceForge's svnnotify installation, which claims to be version 2.80. On my own server, I can't even test this, as svnnotify doesn't seem to be able to gather the full username of the user that did the commit. Hence, the From: field only contain the address, not a name.