search

theory / tap-parser-sourcehandler-pgtap

TAP::Parser::SourceHandler::pgTAP
http://search.cpan.org/dist/TAP::Parser::SourceHandler::pgTAP
11 stars 13 forks source link

PostgreSQL v11 breaks pg_tapgen's _hasc() function #19

Closed KiriakosGeorgiou closed 5 years ago

KiriakosGeorgiou commented 5 years ago

In PostgreSQL v11 pg_class no longer has relhaspkey, so the query the _hasc() function runs is broken. Also, per Tom Lane using relhaspkey in this way is incorrect. I'll submit a pull request fixing this.

wwuck commented 5 years ago

@theory Will there be a new release coming soon for this fix? I've just discovered pgtap and would love to try it out on PostgreSQL 11.

theory commented 5 years ago

v1.0.0 dropped a few days ago.

wwuck commented 5 years ago

Thanks. I will wait for it to appear on apt.postgresql.org before I can test it out. Does that happen automatically, or do I need to submit an issue somewhere else for that?

theory commented 5 years ago

I don't think its automatic. I don't know where the source list hosted, and a quick search didn't turn it up. :-( Suggest you ask in a community forum like IRC or the pgsql-general mail list (subscription instructions).

wwuck commented 5 years ago

I checked the documentation at https://wiki.postgresql.org/wiki/Apt and it looks like the maintainers live on the pgsql-pkg-debian list at https://www.postgresql.org/list/pgsql-pkg-debian/.

Checking the list archives, it looks like you can just announce the new version on there with a pointer to the release on github and one of the maintainers there will do the update.

theory commented 5 years ago

Bah, sorry, it was pgTAP that was released, not pg_prove. I'll try to find some tuits to make a release in the next few days.

theory commented 5 years ago

I've released v3.35 to CPAN. Someone will have to nag the Postgres apt maintainers to update their package.

wwuck commented 5 years ago

https://redmine.postgresql.org/issues/4044

https://redmine.postgresql.org/issues/4045