search

theos / dm.pl

not dpkg-deb, nor a plane, nor a bird.
MIT License
39 stars 22 forks source link

Use POSIX, not GNU extensions #2

Closed tyilo closed 6 years ago

tyilo commented 6 years ago

This fixes https://github.com/theos/theos/issues/295

DHowett commented 6 years ago

is this a bug in Archive::Tar?

kirb commented 6 years ago

Ah! Good catch. So GNU tar doesn’t/no longer supports the tar extension GNU defined…? Or is it possible Archive::Tar is simply generating corrupt data in the first place?

Archive::Tar(3) man page says:

Note that GNU tar earlier than version 1.14 does not cope well with the "POSIX header prefix". If you use such a version, consider setting the $Archive::Tar::DO_NOT_USE_PREFIX variable to "true".

1.14 is from 2004, oldest version I can see on http://apt.saurik.com/debs/ is 1.19 from 2008, so this should be fine as a workaround anyway. Will need to do some testing with various versions of tar (thanks for the test case in theos/theos#295 by the way!).

Also found this unanswered bug report on CPAN that seems to line up with what you reported in the issue thread: https://rt.cpan.org/Public/Bug/Display.html?id=121246

kirb commented 6 years ago

Decided to just go ahead and merge this. Thanks!