Orion broken on arm64e iOS 14 due to Xcode 11 being used.

theos / orion

Elegant tweak development in pure Swift

https://orion.theos.dev

MIT License

216 stars 15 forks source link

Orion broken on arm64e iOS 14 due to Xcode 11 being used. #4

Closed Absolucy closed 3 years ago

Absolucy commented 3 years ago

Orion.framework is compiled with Xcode 11.
Xcode 11 swift apps break on arm64e iOS 14.

Orion tweaks crash in orion_init on arm64e iOS 14:

Call stack:
--
2 | 0   ColoredSwipe.dylib                0x0000000101132e00 0x10112c000 + 28160          // orion_init()
3 | 1   ColoredSwipe.dylib                0x0000000101132ddc 0x10112c000 + 28124          // orion_init()
4 | 2   ColoredSwipe.dylib                0x0000000101132da0 0x10112c000 + 28064          // orion_init
5 | 3   ColoredSwipe.dylib                0x0000000101132828 0x10112c000 + 26664          // init

kabiroberai commented 3 years ago

To elaborate on this, the issue here is that Orion itself is built with Xcode 11 (i.e. the iOS 13 arm64e ABI). We can probably fix this by creating sub-packages and making org.theos.orion itself depend on firmware (< 14.0) | org.theos.orion-14, firmware (>= 14.0) | org.theos.orion-13

Absolucy commented 3 years ago

@kabiroberai couldn't that just be done with 2 packages and provides?

kabiroberai commented 3 years ago

b40a048 should hopefully fix this but we'll only be able to find out when I tag the next release (and the gh action runs), so fingers crossed 🙃

kabiroberai commented 3 years ago

Closing to keep things tidy; if this is still broken once 0.9.2 is released, please reopen the issue.