theos / orion

Elegant tweak development in pure Swift
https://orion.theos.dev
MIT License
216 stars 15 forks source link

Orion broken on Linux #6

Closed arya1106 closed 3 years ago

arya1106 commented 3 years ago

(Thanks for reporting an issue! Please make sure you click the link above to view the issue guidelines, then fill out the blanks below.)

What are the steps to reproduce this issue?

  1. Install Orion
  2. Attempt to compile a tweak

What happens?

Tweak fails to compile

What were you expecting to happen?

Tweak compiles successfully

Any logs, error output, etc?

https://ghostbin.co/paste/52w4

Any other comments?

The same code compiles on macOS

What versions of software are you using?

Operating System: Linux Distro: Ubuntu 20.04 Kernel: 5.8.0-44-generic

Toolchain Version: Swift 5.3.3 from https://swift.org/download/ CRKatri toolchain 5.3.2 from https://github.com/CRKatri/llvm-project/releases/tag/swift-5.3.2-RELEASE

SDK Version: iOS 14.0

kabiroberai commented 3 years ago

Interestingly enough this is probably an issue with the Swift compiler more than it is with Orion, since it's a crash in the compiler itself. Regardless, it probably means the Orion ABI (but hopefully not the public API) will have to be changed somewhat to work around the issue.

I'll also file an issue on the Swift JIRA if/when I figure out the root cause but it'll still be necessary to make the necessary changes to Orion as we can't drop support for all compiler versions before the one where they fix the bug.

SarahH12099 commented 3 years ago

Here is my friends log for this issue: https://pastebin.com/QGKPFHzA

I am not sure if FunctionHook crashing on app launch is the possible same issue as this.

Operating System: Linux Distro: Linux Mint 20.1 Cinnamon Kernel: 5.4.0-70-generic + tetherpatch

Toolchain Version: Swift 5.3.3 from https://swift.org/download/ CRKatri toolchain 5.3.2 from https://github.com/CRKatri/llvm-project/releases/tag/swift-5.3.2-RELEASE

SDK Version: iOS 14.2 (https://github.com/Zi0P4tch0/sdks)

kabiroberai commented 3 years ago

Resolved with 225c463; the fix should land in 0.9.3 :)

arya1106 commented 3 years ago

Nice! Looking forward to trying it out!