theos / theos.dev

Theos website!
https://theos.dev
Other
23 stars 15 forks source link

Add gzip #34

Closed ghost closed 1 year ago

ghost commented 1 year ago

What does this implement/fix? Explain your changes.

This adds gzip to the required dependencies for installing theos on iOS. The Theos installer would error out and not install when gzip wasn't installed.

Does this close any currently open issues?

No.

Any relevant logs, error output, etc?

No.

Any other comments?

No.

Where has this been tested?

Operating System: iOS 14.2

Platform: iOS

Jailbreak: Odysseyra1n

Target Platform: N/A

Toolchain Version: N/A

SDK Version: N/A

netlify[bot] commented 1 year ago

Deploy Preview for theos-site ready!

Built without sensitive environment variables

Name Link
Latest commit b2d90e48bcc7130a519f2d78b99eef5b0d997666
Latest deploy log https://app.netlify.com/sites/theos-site/deploys/64225567970491000865deb6
Deploy Preview https://deploy-preview-34--theos-site.netlify.app/docs/installation-ios
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

L1ghtmann commented 1 year ago

Nice catch! I had previously assumed it would be preinstalled since most package managers depend on it (I think?).

The dependencies listed in the docs are just those required to run the install script, the actual build system dependencies are referenced in the installer itself, so it may be worth making this change there instead (https://github.com/theos/theos/blob/165cb1d6106907e2cab4c615f25faf5123d7d35c/bin/install-theos#L223).