Open daniel-ji opened 8 months ago
Thank you very much for this feedback which is super useful.
On security vulnerabilities: in general I don't tend to worry too much about security vulnerabilities for client-side apps. Looking quickly into that d3-color
issue, it's basically that if you deploy on a server someone can create malicious input that could cause your server to use tons of CPU. But in this case users can just create malicious input that does that to their own computers :) However in fact the way Taxonium is built I think there are a lot of dependencies that aren't really needed (they are already packaged) so I should be able to remove these messages.
Thanks for flagging the warnings, will see what I can do there, and yes I should upgrade to react 18. Thank you for noting that workaround - will try to at minimum document that.
Thanks again!
Hi,
I was the student under @niemasd that was working to get the React component working on a web app (I've been a bit busy over the past month, apologies that it took so long for me to get around to). I've gotten it working and it's great, awesome tool! Setting it up was really easy and intuitive! I thought I'd leave some feedback on some things I encountered when setting up taxonium-component (actual development / coding was a smooth-sailing process):
The project (https://github.com/niema-lab/ViralWasm-Epi/) currently using React 18 and Taxonium was expecting React 17, so I had to run
npm i taxonium-component --legacy-peer-deps
. When running this command, I also got the following warnings:It also seems like it has a security vulnerability and I thought that I'd just add that in here too:
Thank you!
Daniel