theothernt / AerialViews

A screensaver for Android TV devices including Nvidia Shield, Fire TV, and Chromecast with Google TV. Inspired by Apple TV's video screensaver.
GNU General Public License v3.0
415 stars 32 forks source link

POI showing filenames #108

Closed Thoroslives closed 1 year ago

Thoroslives commented 1 year ago

Been using for a while on a Nvidia Shield pulling files locally from a samba share on my server. POI namrs havr been working fine so far but have recently noticed some of them, which seem to be any non apple ones ive found linked around this github are now showing file names as POI. (Such as video_inspire_oregon_lone_ranch_beach_00015)

Settings are

Running 1.4.3

theothernt commented 1 year ago

Thanks for reporting the issue. What you're seeing is a bug, basically a copy and paste mistake by me, but it's fixed in 1.4.4 due out soon.

Did you only see this issue with one video?

Thoroslives commented 1 year ago

Thanks for reporting the issue. What you're seeing is a bug, basically a copy and paste mistake by me, but it's fixed in 1.4.4 due out soon.

Did you only see this issue with one video?

Nah it happens with essentially any video that isnt an official apple one. Ive got about 140 vids that the app pulls which includes the apple ones.

theothernt commented 1 year ago

Hmmm... it's possible there's another issue then.

Let me check on it tomorrow, I'll use a mix of a Apple + Community videos.

Thoroslives commented 1 year ago

Hmmm... it's possible there's another issue then.

Let me check on it tomorrow, I'll use a mix of a Apple + Community videos.

Im sorry, if you give me till this evening ill go through and can tell you which ones work and dont

theothernt commented 1 year ago

Im sorry, if you give me till this evening ill go through and can tell you which ones work and dont

That's ok, I know what the issue is - I realised right after I replied.

Basically, POIs are not added to videos from SMB, USB storage as I forgot to implement it.

I'll fix it tomorrow - and thank you so much for letting me know! 😅

Thoroslives commented 1 year ago

Im sorry, if you give me till this evening ill go through and can tell you which ones work and dont

That's ok, I know what the issue is - I realised right after I replied.

Basically, POIs are not added to videos from SMB, USB storage as I forgot to implement it.

I'll fix it tomorrow - and thank you so much for letting me know! 😅

Awesome, more than happy to help, let me know when you push and ill give it a test

theothernt commented 1 year ago

Ok, I've added a quick fix which should include POI info for community videos... (link removed)

Let me know how you get on!

Thoroslives commented 1 year ago

Ok, I've added a quick fix which should include POI info for community videos... (link removed)

Let me know how you get on!

Sorry ive sent sway with work so i wont be able to test it out till next week.

theothernt commented 1 year ago

Sorry ive sent sway with work so i wont be able to test it out till next week.

No problem at all, I'll let you know when I release it.

Thoroslives commented 1 year ago

For some reason the 1.44 beta patch wont install over the existing installation, am I gonna have to do a cleaninstall?

theothernt commented 1 year ago

For some reason the 1.44 beta patch wont install over the existing installation, am I gonna have to do a cleaninstall?

How are you trying to install it?

Thoroslives commented 1 year ago

All good just did a clean install, on a nvidia sheild btw.

This patch seems to have fixed it, ive scrolled through a bunch and havent seen any with the bug yet

theothernt commented 1 year ago

Great! glad it's fixed - the fix will be included in the next release of the app.

theothernt commented 9 months ago

Just to double check, are you running the latest version of the app (1.5.2 currently) ?

I ask as I'm getting crash reports from a user running 1.4.4-beta which is quite old.

Thoroslives commented 9 months ago

Just to double check, are you running the latest version of the app (1.5.2 currently) ?

I ask as I'm getting crash reports from a user running 1.4.4-beta which is quite old.

Im still running that beta apk you gave me, its been flawless

theothernt commented 9 months ago

Just to double check, are you running the latest version of the app (1.5.2 currently) ? I ask as I'm getting crash reports from a user running 1.4.4-beta which is quite old.

Im still running that beta apk you gave me, its been flawless

Glad to hear it!

I would recommend updating to a non-beta version when you have time. If you update to v1.5.2, it will carry your preferences forward - there are also new videos and features 😊