search

theothernt / AerialViews

A screensaver for Android TV devices including Nvidia Shield, Fire TV, and Chromecast with Google TV. Inspired by Apple TV's video screensaver.
GNU General Public License v3.0
415 stars 32 forks source link

Mute not working for SMB videos #132

Closed cosmoxl closed 4 months ago

cosmoxl commented 5 months ago

https://old.reddit.com/r/ShieldAndroidTV/comments/1afg2uw/aerial_views_screensaver_not_muting_smb_videos/

Moving this reddit conversation here at the request of theothernt to better track the problem. Thanks for looking into it.

theothernt commented 5 months ago

Thanks for creating the issue.

This bug is odd but it's also the 2nd bug related to the Shield recently. Both are simple playback issues that shouldn't happen.

What I'd like to try is to give you an old debug version of the app, maybe from a year ago, and see if that works. If it does, we can go from there and narrow down the issue. The debug version of the app will not override the Play Store version you have installed.

cosmoxl commented 5 months ago

Thanks for creating the issue.

This bug is odd but it's also the 2nd bug related to the Shield recently. Both are simple playback issues that shouldn't happen.

What I'd like to try is to give you an old debug version of the app, maybe from a year ago, and see if that works. If it does, we can go from there and narrow down the issue. The debug version of the app will not override the Play Store version you have installed.

sounds good

theothernt commented 5 months ago

Ok, here is (link removed) - let me know if this has the same issue

cosmoxl commented 5 months ago

Ok, here is (link removed) - let me know if this has the same issue

Yes, same problem with audio playing though mute option is ticked. This version also has another thing I'd noticed in the recent release and that's that more often than not there's corruption of the video - either a strip on the right side or a strip on the bottom. Seems like bottom for 4:3 aspect ratio videos, and right side corruption for videos wider than 16:9.

theothernt commented 5 months ago

Ok, here is (link removed) with a small change to set the volume to zero every time a new video is played.

As for the visual corruption issue, we may have to look into that later as a separate issue.

In the meantime, can you download a free video player app called Just Player. It uses the same player as Aerial Views (Media3/ExoPlayer) so it can help to narrow down the issue to my app/code or ExoPlayer itself. Try to play the same video clips and see if you get the visual corruption.

cosmoxl commented 5 months ago

Sorry, no difference with the 1.6.3-debug with regard to the audio playing.

theothernt commented 5 months ago

Sorry, no difference with the 1.6.3-debug with regard to the audio playing.

Ok, he is (link removed) - this time it disables the audio track inside the video, so the volume doesn't matter.

Also, I did just think of something. Is your Shield directly connected to your TV or does the audio go through another device?

cosmoxl commented 5 months ago

Sorry, no difference with the 1.6.3-debug with regard to the audio playing.

Ok, he is (link removed) - this time it disables the audio track inside the video, so the volume doesn't matter.

Also, I did just think of something. Is your Shield directly connected to your TV or does the audio go through another device?

The shield is connected to an AVR then to the TV. The good news is that this did the trick for "muting" :D

theothernt commented 5 months ago

Great, that's another bug fixed. It'll be in the next release but that's a few weeks away, at least.

Next is the video corruption you're seeing. Is this only with your custom videos?

cosmoxl commented 5 months ago

Great, that's another bug fixed. It'll be in the next release but that's a few weeks away, at least.

Next is the video corruption you're seeing. Is this only with your custom videos?

yeah, and I see the same corruption in just video player. it's due to the cropping to fill the screen, which is sort of necessary for a screen saver. So for widescreen it crops the sides, for 4:3 it crops the top and bottom.

theothernt commented 5 months ago

Would it help to be able to turn off the crop? Just Player allows you to toggle this while playing to test if it helps or not.

cosmoxl commented 5 months ago

Would it help to be able to turn off the crop? Just Player allows you to toggle this while playing to test if it helps or not.

I think the crop to fill the screen is necessary but some people might like the option. The point of the screensaver is still being accomplished even if it's not pretty along the bottom or side. :)

theothernt commented 4 months ago

Version 1.7 has been released with this fix on GitHub, it'll be on the Play Store in a few days.