Closed dog77k closed 2 months ago
theothernt
commented
2 months ago Thanks for spotting that, it'll be fixed in the next release.
Given that the app handles images now, do you think I should ignore d-pad up/down when an image is being displayed ie. you can only change the playback speed while a video is playing?
dog77k
commented
2 months ago Yeah, good call. Either ignore or possibly change the slideshow speed if a picture is displayed.
On Sun, Apr 21, 2024, 8:19 AM Neil Turner @.***> wrote:
Thanks for spotting that, it'll be fixed in the next release.
Given that the app handles images now, do you think I should ignore d-pad up/down when an image is being displayed ie. you can only change the playback speed while a video is playing?
— Reply to this email directly, view it on GitHub https://github.com/theothernt/AerialViews/issues/142#issuecomment-2068040929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFI32LNTHKVPVUUTRQCGFADY6O4FXAVCNFSM6AAAAABGRA6XYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYGA2DAOJSHE . You are receiving this because you authored the thread.Message ID: @.***>
theothernt
commented
2 months ago It looks like any speed change made was not being saved. By simply saving the change, the toast is correct.
So, if you have playback speed set to 1x. Start the screensaver, increase speed to 2x, exit the screensaver. Either check the Playlist prefs or start the screensaver again and it should be at 2x.
Also, by chance, if video playback is not active (ie. images are being shown) - d-pad up/down is ignored
When I change the current playback speed the d-pad up and down, the speed actually changes, but the toast message always shows the preferences setting speed, not the actual current speed.
It seems like the fix would be something like changing "GeneralPrefs.playbackSpeed" to "videoPlayer.playbackSpeed" in handlePlaybackSpeedChanged() of ScreenController.kt