search

theothernt / AerialViews

A screensaver for Android TV devices including Nvidia Shield, Fire TV, and Chromecast with Google TV. Inspired by Apple TV's video screensaver.
GNU General Public License v3.0
469 stars 35 forks source link

Support playback speed #20

Closed marcopar closed 3 years ago

marcopar commented 3 years ago

Added preference to change the playback speed in steps from 0.25 to 4. Tried also 5 but it stutters a lot on my TV in 4K HDR....it may be that maximum play speed is device dependent and network bandwidth dependent

marcopar commented 3 years ago

Looks like there's an issue when the video ends. It doesn't switch to the next one and remains stuck on the last frame. I'll take a look.

theothernt commented 3 years ago

Sounds like a great feature to add - let me know if you fix the issue you mention?

theothernt commented 3 years ago

@marcopar I think I may know what the bug is. For the videos to fade, a timer is set to the length of the video minus the fade time. When you increase the video playback speed, the length of the video may still be reported as 100%.

So if a video is 1 min long, playing at 2x speed, the video will finish playing after 30 secs then stop until 58secs when the fade starts.

Anyway, just a guess :)

marcopar commented 3 years ago

Looks like that's the case, if you wait enough it will fade to the next video

marcopar commented 3 years ago

Fixed

theothernt commented 3 years ago

Ok, I'll probably merge this towards the end of the week (24/09/2021) assuming you find no issues, etc

Update: I've just merged a branch which renames the app so you'll just have to rename a few things!

theothernt commented 3 years ago

Happy to accept the PR if you'd like to have a go at the merg?

marcopar commented 3 years ago

I can't see what conflicts are there

theothernt commented 3 years ago

On the GitHub website, you can view your own fork on this repo - then click on 'Fetch upstream', you should be able to handle the merge + fixes from there.

marcopar commented 3 years ago

uh...i didn't notice they added a fetch upstream magic button....great i'll take a look asap

theothernt commented 3 years ago

Yeah, it's really handy... not sure when they added it either!

No hurry on the PR btw.

marcopar commented 3 years ago

it was a wild journey in git space but i think i merged correctly

theothernt commented 3 years ago

Thanks for all that work, I'll merge it now and start testing!