theothernt / AerialViews

A screensaver for Android TV devices including Nvidia Shield, Fire TV, and Chromecast with Google TV. Inspired by Apple TV's video screensaver.
GNU General Public License v3.0
418 stars 32 forks source link

Location Text is Blurry on Sony A80J (and other 4K TVs) #81

Closed kennethshsu closed 1 year ago

kennethshsu commented 1 year ago

What were you trying to do... When the location text is enabled, the text appears blurry. The clock text is very clear.

And what actually happened (ie. describe the bug)... Text appears blurry

What kind of device do you have? (eg. Nvidia Shield, Sony TV, etc)... Sony A80J (2021)

theothernt commented 1 year ago

Thanks for reporting the issue.

Is there any way you could take a photo or screenshot of the text so I have a better idea?

Also, are you running the latest version of the app?

kennethshsu commented 1 year ago

I tried taking a picture but I don't think it captures what you actually see. I'm on v1.3.2 from the Play store.

The best way for me to describe the problem is that, for some character with straight lines, for example "H", or "L", the lines don't sit tightly within a set pixel column, they "spills over".

theothernt commented 1 year ago

So my guess is that in certain languages the text/characters might not look right due to the text size. I'll add this to a list of things to test in future (eg. Russian, Chinese, Japanese, etc).

The fix would be to allow you to tweak the text size a bit - if the default for English is 10pt, then I should add option for 12pt, 14pt, etc which should fix the issue.

(I'm mentioning other languages as I'm sure it's a general problem)

kennethshsu commented 1 year ago

We can try that, but I'm seeing the problem with English as well.

Please keep me posted when you release a new version and I can help you watch for it. Thank you!

Nxt3 commented 1 year ago

I am seeing the same thing on my Hisense U8G. I think the problem stems from the thin font + shadow

If the fonts were changed to maybe just sans-serif, that might fix it? or maybe removing or adjusting the shadow on those words.

theothernt commented 1 year ago

I am seeing the same thing on my Hisense U8G. I think the problem stems from the thin font + shadow

And just to confirm, this is a 4K screen?

Nxt3 commented 1 year ago

I am seeing the same thing on my Hisense U8G. I think the problem stems from the thin font + shadow

And just to confirm, this is a 4K screen?

That is correct, 4k.

Here's a pic, but honestly, the camera isn't capturing the issue. It looks somewhat blocky/pixelated irl.

PXL_20221107_213201010.MP.jpg

kennethshsu commented 1 year ago

Are you seeing no or less of an issue when the video is not HDR? I think that the issue is more severe when HDR videos are playing in the background, but it's hard to visually confirm this.

theothernt commented 1 year ago

Would either of you be interested in trying a beta version of the app - I can make some changes to the font size and see if that fixes the issue?

Nxt3 commented 1 year ago

Are you seeing no or less of an issue when the video is not HDR? I think that the issue is more severe when HDR videos are playing in the background, but it's hard to visually confirm this.

I would need to check this. I've only been using HDR content.

Would either of you be interested in trying a beta version of the app - I can make some changes to the font size and see if that fixes the issue?

Yes! Would love to help out.

kennethshsu commented 1 year ago

Would either of you be interested in trying a beta version of the app - I can make some changes to the font size and see if that fixes the issue?

Yap, I can help test this as well.

kennethshsu commented 1 year ago

Are you seeing no or less of an issue when the video is not HDR? I think that the issue is more severe when HDR videos are playing in the background, but it's hard to visually confirm this.

I would need to check this. I've only been using HDR content.

You can download a SDR video and try to play it locally. Or just select the SDR Apple stream from the menu. Let me know what you see, I'm curious as well.

theothernt commented 1 year ago

Thanks to you both!

I should have a build ready in the next day or so. The plan is to add a couple of extra options...

  1. Toggle the shadow on and off
  2. Change the size of the text from a preset list
kennethshsu commented 1 year ago

Great, happy to help test out these options when ready.

theothernt commented 1 year ago

Ok, here is a test version of the app: (link removed)

Look in Settings > Interface for the 2 new options.

kennethshsu commented 1 year ago

I see the new options now. It's hard to see if it's improved because I had to uninstall the stable version so I can't directly compare.

Disabling drop shadow I think improved it the most, I'm now on 22 points for location text size. However, removing the drop shadow makes it harder to read with some videos, can we try uniformed outlines or something else?

Also, can you put the version somewhere in the app?

kennethshsu commented 1 year ago

I just got a chance to do a bit more testing. I don't think the problem is from the font size or the drop shadow effect. If you pay close attention, when you advance to the next video, the texts are perfectly clear for a split second at the beginning of the video.

theothernt commented 1 year ago

Thanks for the update @kennethshsu.

Typically when a video starts, the text is faded in. So this could be an issue with the way Android handles fades. I may add some options into Beta 2 to disable the fading and see what happens (as I'm unable to test any of this at the moment)

kennethshsu commented 1 year ago

Is there a reason why the clock is ok but the location text isn't?

Let me know if you want me to help test another release. Thanks for the hard work!

theothernt commented 1 year ago

Well, that's the issue I'm trying to figure out. The only technical differences are the size of the text and the transparency + shadow settings. I may make them both have the same settings just to see if that fixes the issue.

kennethshsu commented 1 year ago

Ok sounds good, please keep me posted.

theothernt commented 1 year ago

Here is an update version: (link removed)

Basically, the Clock and Location text have the same values in terms of colour, opacity and shadow.

Let me know if it makes a difference?

kennethshsu commented 1 year ago

I'm still seeing the same issue. Do they have the same font style?

theothernt commented 1 year ago

I'm still seeing the same issue. Do they have the same font style?

Yes, but I'll go through the code again and see if anything is changed at run-time.

theothernt commented 1 year ago

Just to rule out recent changes to the app, would it be possible for you to test an older version of the app...

Maybe v1.1 or v1.2 ?

kennethshsu commented 1 year ago

Sure, can you upload the apks here?

theothernt commented 1 year ago

Sure, can you upload the apks here?

Yes, they're all on the Releases page.

kennethshsu commented 1 year ago

Hmm, so I looked at v1.2.

v1.2 looks pretty bad. Both the time and location texts are extremely hard to read, especially on brighter videos. However, it's even worse for location text compared to the time. Comparing between version (v1.2 vs the beta), the location texts are the same, but the time text is much easier to read now.

What changed?

theothernt commented 1 year ago

Between those two versions, I brightened the text and made it less transparent - but I'm only able to test on 1080p / SDR at the moment.

My guess is there's an issue with displaying text (which I think is in SDR) on top of a HDR video. The video will always be brighter. I'll have to do some more research.

kennethshsu commented 1 year ago

You need someone to donate you a 4k HDR TV! 🤣

Can you make a slider or menu option for the text transparency/brightness? I can help test that too.

theothernt commented 1 year ago

Another small update to test... Aerial Views v1.3.3 beta 3

The text (time and location) is set to full white - just curious if this will look any better than the off-white colour I was using previously.

kennethshsu commented 1 year ago

v1.3.3 beta 3 made no difference as well.

However, I found something that might be useful to you. When I launch screensaver from within the app by testing the screensaver, the problem isn't there. However, if the screensaver is launched by the OS, the problem shows up. This behavior is observable from the stable version that is currently on the Google Play Store as well.

I wonder if this is an OS problem?

theothernt commented 1 year ago

I wonder if this is an OS problem?

Hmmm, it might be given what you've seen.

The code for testing the screensaver and running it (called by the OS) is basically the same. Strictly speaking, two different screens are called, but they initialise the screensaver code and add it to the window. Very odd!

If you wouldn't mind, could you test Aerial Dream as well? this should rule out if it's an issue with the OS or not.

kennethshsu commented 1 year ago

I just tested Aerial Dream, the texts don't look as white as Aerial View's clock, which is the desired look. Aerial Dreams clock and location text don't look blurry though, they just aren't as white or as bright.

Aerial Dream's testing screensaver button vs screensaver launches by the OS look identical to me.

theothernt commented 1 year ago

Ah, I forgot - I don't think Aerial Dream plays the HDR versions of the videos, are you seeing Dolby Vision being activated?

Also, with Aerial Views, are you not seeing the issue if you use the 4K SDR version of the videos?

kennethshsu commented 1 year ago

You are right, Aerial Dream plays all videos in SDR, which is why everything looks fine.

For Aerial View, I am seeing the same issue with SDR videos: launching from the app looks ok, launching by the OS location text is blurry.

theothernt commented 1 year ago

If anyone has some free time, would it be possible to get some screenshots from the device itself?

After a quick search, the method seems to be - you press the power and volume down buttons simultaneously

kennethshsu commented 1 year ago

Wow, I think I figured out the bug.

This bug only occurs when you put the TV in "App Only Mode". @Nxt3 are you in App Only Mode? Can you try disabling that?

I only discovered this because I ran into some trouble taking screenshots when being in App Only Mode, and after some hoops I realized that the bug went away when I went out of App Only Mode.

Nxt3 commented 1 year ago

Wow, I think I figured out the bug.

This bug only occurs when you put the TV in "App Only Mode". @Nxt3 are you in App Only Mode? Can you try disabling that?

I only discovered this because I ran into some trouble taking screenshots when being in App Only Mode, and after some hoops I realized that the bug went away when I went out of App Only Mode.

Maybe? I'm not actually sure what "App Only Mode" is 😅

kennethshsu commented 1 year ago

Maybe? I'm not actually sure what "App Only Mode" is 😅

It's basically like disabling all the smart features (like movie recommendations, sports scores, etc), it removes a bunch of junk.

I wonder if @Nxt3 can confirm this, if so, it is indeed a system's bug and not the app and we can close out this ticket.

theothernt commented 1 year ago

@Nxt3 these instructions for Google TV should work...

https://support.google.com/googletv/answer/10070784?hl=en

kennethshsu commented 1 year ago

Actually, does that make sense, even if it works outside of App Only Mode, is this really an OS issue?

Nxt3 commented 1 year ago

I'm definitely not in "App Only Mode".

kennethshsu commented 1 year ago

Interesting. By the way, @theothernt, I tried taking screenshots, but the pictures come out super weird (lots of pink colors all over the picture), I think this is due to HDR videos playing over it.

theothernt commented 1 year ago

Interesting. By the way, @theothernt, I tried taking screenshots, but the pictures come out super weird (lots of pink colors all over the picture), I think this is due to HDR videos playing over it.

Damn, that's probably because screenshots are 8bit and HDR requires 10bit...

theothernt commented 1 year ago

I'm going to close this issue for the moment, but keep an eye out for additional font + size options in the next couple of releases.