search

theowenyoung / foam-template-gatsby-theme-primer-wiki

Another Foam template that use gatsby-theme-primer-wiki
https://demo-foam.owenyoung.com/
MIT License
38 stars 13 forks source link

Foam on CI #2

Closed Casyfill closed 3 years ago

Casyfill commented 3 years ago

One thing I noticed with the gatsby-wiki theme, but probably applicable anywhere else, is that it is sometimes tempting to edit/work on the repository via online tools (especially given this wonderful "edit" button). Both Gitlab and Github now has built-in VS-code, so this is very convenient. However, those do not have FOAM installed (duh), which means there won't be any link ref generation. So it would probably be safe to have foam-cli run janitor anyway right before running gatsby build.

theowenyoung commented 3 years ago

Thanks, that makes sense, I'll add it to the ci.

theowenyoung commented 3 years ago

fixed. see: https://github.com/theowenyoung/foam-template-gatsby-theme-primer-wiki/blob/main/.github/workflows/deploy.yml#L36

Casyfill commented 3 years ago

Isn’t it processing .layouts folder, instead of root?

On Thu, Oct 14, 2021 at 14:51 Owen Young @.***> wrote:

fixed. see: https://github.com/theowenyoung/foam-template-gatsby-theme-primer-wiki/blob/main/.github/workflows/deploy.yml#L36

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theowenyoung/foam-template-gatsby-theme-primer-wiki/issues/2#issuecomment-943630278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUNHJMOO6IFV6SYL3QRT7TUG4RCZANCNFSM5F767FHA .

theowenyoung commented 3 years ago

yes, foam-cli docs say we should give it the workspace path, so it should be root.

I have tested this, it works fine.