Added support for multiple wallets balance

thepalbi / ethereum-prometheus-exporter

Prometheus exporter for Ethereum client metrics

MIT License

1 stars 0 forks source link

Added support for multiple wallets balance #31

Closed evictorero closed 2 years ago

evictorero commented 2 years ago

Changed config to support múltiple wallets (name and address)
Changed hexutil.Uint64 result type to hexutil.Big to support bigger numbers as balances are expressed in WEI
Added example of wallet config to sample.yaml file

leandro-deveikis commented 2 years ago

I approved as it seems ok, but 2 little things:

balance, _ := new(big.Float).SetInt(result.ToInt()).Float64() is casting is ok? I could not look into that but I would make sure we are not looking information in the process
Would change wallet for wallets at yaml file

evictorero commented 2 years ago

I approved as it seems ok, but 2 little things:

balance, _ := new(big.Float).SetInt(result.ToInt()).Float64() is casting is ok? I could not look into that but I would make sure we are not looking information in the process

Would change wallet for wallets at yaml file

I didn't find a better way to convert a big.Int to a float64
Agree, changed ✅