thepassle / generic-components

A collection of generic web components with a focus on accessibility, and ease of use
https://genericcomponents.netlify.app/
MIT License
558 stars 29 forks source link

Add default gap between tabs #51

Closed davatron5000 closed 3 years ago

davatron5000 commented 3 years ago

One issue we (@bkardell, @jonathantneal, and I) noticed with the default Tabs style was that the headings variant looked like CamelCase instead of two distinct tabs. This PR fixes that.

⚠️ This is probably a breaking change since it modifies the base element styles. Not sure how you want to approach that.

thepassle commented 3 years ago

This is still in RC phase, so breaking changes are still ok now 🙂

Thanks for the PR!