Closed suanjiansalt closed 10 months ago
Decide to localize all killing tip strings. Sorry for the wavering.
All of these "Eliminate \
I've only really looked at the the first contract in the list, MENDIE1, and that one already was wrong: your new edit says that the kill needs to be an explosion accident, where any kill method is sufficient.
It also looks like you changed the locr key UI_PEACOCK_SOUTHERN_COMFORT_OBJ1
to UI_PEACOCK_SOUTHERN_COMFORT_XMASGIFT
, but in doing so changed the text for all languages to the english translation.
I'll do some more testing later
All of these "Eliminate
" lines without any condition don't really need dedicated localization and create unnecessary work for the translators, the generic UI_CONTRACT_GENERAL_OBJ_KILL should work fine
- I did this because in H3, almost official escalations really localized all strings like "Eliminate
". For example, in the Jinzhen Incident: Just eliminating Shihong Luo and Hui Hou in any conditions are both localized. Again, as I said earlier, if it's not necessary, just delete it. I've only really looked at the the first contract in the list, MENDIE1, and that one already was wrong: your new edit says that the kill needs to be an explosion accident, where any kill method is sufficient. - Oh YES, it is my fault. Not understand why I did it, but it clearly a fault I made on purpose. It also looks like you changed the locr key
UI_PEACOCK_SOUTHERN_COMFORT_OBJ1
toUI_PEACOCK_SOUTHERN_COMFORT_XMASGIFT
, but in doing so changed the text for all languages to the english translation.- Well, I'm not merely replace the whole line with new key
UI_PEACOCK_SOUTHERN_COMFORT_XMASGIFT
. All I did in fact is change the keys' names, so I also give the right value to the keys if you look into it. This happens to some complications of The Jeffery Confession too.
Alright, did a quick test with an xmax explosive, seems to work nicely.
The tileimage for the christmas calamity is broken with this change however, it would need to be updated in the image pack.
Thanks @suanjiansalt!
Improvement program for issue #353 , huge thanks to @grappigegovert .
A dumb try, so please treat this as a pupil's homework, after all it's my first time doing this...
Note:
The Christmas Calamity
gameplay.If it's broken, I'm appreciated to receive your kind advice.This time I fixed it correctly. If it's unnecessary, I will rollback it in no time.HUDTemplate
line looks improper inThe Tedious Thievery
. Before you collect all items (7 golds and 2 burgers) the icon is exactly the 'Exit' icon, but after completion the icon is what we want (a blue 'objective' icon).I deletedI changed theOnActive
line but this could be ridiculous. Please inform me before I look too stupid.iconType
to16
and it looks good now.