search

thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

Peacock Patcher appears very blurry when using 125% scaling in Windows on a 1080p display #395

Closed thecatontheceiling closed 6 months ago

thecatontheceiling commented 7 months ago

Describe the bug read the title

To reproduce

  1. Right click on the desktop
  2. Click "Display Settings"
  3. Set scaling to 125% (default is 100%)
  4. Open Peacock Patcher and observe
RDIL commented 7 months ago

Hey, thanks for the report! Can you please try out our experimental core patcher and see if the issue still persists? (patcher-ui-windows artifact)

thecatontheceiling commented 7 months ago

sure thing! do I just need to replace the .exe file with this and it shouldn't mess with anything else?

RDIL commented 7 months ago

Correct

thecatontheceiling commented 7 months ago

the updated patcher does not have this issue. crystal clear image

thecatontheceiling commented 7 months ago

why is it 200 mb though? lol the old patcher isnt even a megabyte

RDIL commented 7 months ago

The old patcher runs on .net framework, where it uses the system’s install of it. The new version uses .net core, which doesn’t come on windows by default like .net framework does. Also, winforms, the library used for creating the gui, does not support dead code elimination when creating complete binaries as of right now, so theres a bunch of extra winforms stuff in there not being used.

it’s not ideal, but we’re looking into ways to reduce the size before promoting the new patcher into stable.

tl:dr; we know its bigger, we’re working on it. The size comes from the combination of .net core and winforms both being bundled in.

RDIL commented 7 months ago

Glad to hear the new patcher fixes the problem! The size concern is absolutely valid though, and it’s something we’re working on minimizing.

thecatontheceiling commented 6 months ago

peacock 6.6.0 has the updated patcher and therefore this issue can be closed. thanks.