thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

fix: escalation jeffery, kasturi #400

Closed suanjiansalt closed 6 months ago

suanjiansalt commented 6 months ago
RDIL commented 6 months ago

Looks like this causes the tests to fail

suanjiansalt commented 6 months ago

Looks like this causes the tests to fail

Noticed this: image

Is it necessary to change the format like

{
    "Targets": [
        "abc"
    ]
}

into:

{
    "Targets": ["abc"]
}

to pass the test? If so, is there a way to substitute normal Prettier plugin with this format type?

grappigegovert commented 6 months ago

Normal prettier should already format it on a single line. If you have the entire repo cloned you can run yarn prettier, to format everything, but judging by the fact that you're uploading this through the web ui, you might not have. What are you using currently to edit/format the files?

suanjiansalt commented 6 months ago

What are you using currently to edit/format the files?

I edited on VSCode with this expansion installed: image

But I prefer to paste lines to github web to commit because I don't get familiar to the steps you commit in VSCode.

grappigegovert commented 6 months ago

If you press ctrl+shift+p to open vscode's command palette, you can do 'Format Document With ...' and then select Prettier. It's not selected by default for some reason, I'll push a fix for that.

grappigegovert commented 6 months ago

You closed the PR?

suanjiansalt commented 6 months ago

bruh, misoperation

RDIL commented 6 months ago

But I prefer to paste lines to github web to commit because I don't get familiar to the steps you commit in VSCode.

https://www.youtube.com/watch?v=B8RSMBSzFuA