search

thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

Challenges Unlocking Starting locations duplicate that start. #435

Closed lazyRares closed 3 months ago

lazyRares commented 5 months ago

The Bug Completing a challenge that unlocks a starting location will duplicate that starting location if the user has already chosen to have all gear/starting locations unlocked.

To reproduce Should be doable on any map that has a challenge that will unlock a starting location. But in my scenario I did this on Marrakesh with the Consulate Parking Garage starting spot, and the 'Floor It!' challenge.

  1. Go To Marrakesh
  2. (Optionally) Check Starting Locations
  3. Complete 'Floor It!'
  4. Check Starting Locations, Duplicate of Consulate Parking Garage visible.

image

RDIL commented 5 months ago

Can you send a zipped copy of your userdata please? I want to see what’s going on with your unlockables.

lazyRares commented 5 months ago

https://www.dropbox.com/scl/fi/rdh54kmq49m3r7xlndlor/userdata.zip?rlkey=imr1k8vydf9g69me6iv45da39&dl=0

grappigegovert commented 5 months ago

Are unlockables even stored in userdata? Isn't this just grantDrops being called while it shouldn't?

RDIL commented 5 months ago

I think they are, @AnthonyFuller can we just early return safely in grantDrops if the flag isn't set to enabling mastery?

AnthonyFuller commented 5 months ago

Unlockables are not stored in userdata, they're dynamically generated. We should be able to safely return grantDrops after granting XP.