thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

The contracts repo cannot be pulled due to invalid filename #446

Closed prolium closed 5 months ago

prolium commented 5 months ago

This file has an invalid character which is preventing the repo from being pulled https://github.com/thepeacockproject/Contracts/blob/main/contracts/h3/%161-20-8070895-27%20XB%3A3-20-9219494-69.json

Error on Windows:

$ git pull origin
error: invalid path 'contracts/h3/?1-20-8070895-27 XB:3-20-9219494-69.json'
Updating 4f6976da..5536cc93

Notice the question mark ? and colon : characters, on Windows these are illegal characters, hence pulling fails

RDIL commented 5 months ago

Just deleted. I'll put some extra validation in place to make sure this doesn't happen again.

prolium commented 5 months ago

Thank you so much