thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

"Chameleon" challenge is bugged and resets after save reload/mission restart #450

Closed Watchman3001 closed 4 months ago

Watchman3001 commented 5 months ago

Describe the bug Pretty much in the title. That challenge in vanilla is cumulative, not requiring you to get all disguises in one sit, that would be a slog on some missions

To reproduce Go to a mission where you don't have that challenge completed, get a disguise, reload a save, try again, and you will see that it got reset to 0

Additional context Tested it a lot on "The Icon" and "Landslide". Double checked that it is not a mod issue, some tests were run on clear Peacock. Quite a serious issue, hope it can be fixed

Watchman3001 commented 5 months ago

After some tests and comparisons (thanks to members of Peacock Discord) it might be some strange consequence of progress transfer procedure

Edit: Test on fresh peacock (empty userdata and no prior progress transfer) showed no such bug, it is definitely something about Progress Transfer procedure breaking it

Watchman3001 commented 4 months ago

Another addition - that same bug messes up Sniper Assassin mode. As soon as I kill a bodyguard, and some challenge related to that starts counting, game crashes. Sent Debug to Mr Fuller. Looks like Progress Transfer breaks a lot of challenge related things

RDIL commented 4 months ago

Fixed in 8cb7378