thepeacockproject / Peacock

The Peacock Project is a HITMAN™ World of Assassination trilogy server replacement.
https://thepeacockproject.org
GNU Affero General Public License v3.0
367 stars 57 forks source link

Fix #437 #458

Closed Yanrishatum closed 4 months ago

Yanrishatum commented 4 months ago

Scope

This PR fixed #437 by introducing an inLocation field along with inGroup field. This fixes ability to remove global challenges, as their ParentLocationId is "", not their virtual location scope. As a consequence it fixes the challenge packs where first registered challenge is a global challenge.

This PR can be safely cherry-picked to v7, as it's a fix intended for plugin developers.

Checklist