search

thepeacockproject / linux-steam-setup

Helper scripts and utilities for running Peacock on Linux, mainly targeting the Steam version of the game.
https://thepeacockproject.org/wiki/guides/linux-setup
17 stars 2 forks source link

Adjust Linux setup instructions #6

Closed elken closed 10 months ago

elken commented 10 months ago

Open to further critique here, but I think this is a much more streamlined setup.

Confirmed to work on the deck too even in gaming mode, I can add some notes about managing the windows in gaming mode if needed.

The startup script is also quite lax with error handling, but there's not a lot of moving parts here and I figure the README has a fair bit of it covered.

alex73630 commented 10 months ago

First, thanks for your PR! Help enhancing this guide is highly appreciated!

I just have two questions/discussion points in regards to this PR:

  1. If we are requiring curl, why not drop the need of wget and just use curl for everything? That would reduce the dependencies needed while providing the same experience in the end.
  2. As for the usage of a service, it's a really clever idea but I feel we need to have clear instructions on how to use it for novice Linux users (which most Steam Deck users are). Perhaps some extra notes and instructions about the fact that Peacock will run in the background indefinitely (even if it should have low to no impact on performance at idle), how to start and stop it and how to see logs should help in that regard.

I'll try to make time to test it out on my Deck this weekend but I don't see any major issue on the PR itself

elken commented 10 months ago

First, thanks for your PR! Help enhancing this guide is highly appreciated!

I just have two questions/discussion points in regards to this PR:

  1. If we are requiring curl, why not drop the need of wget and just use curl for everything? That would reduce the dependencies needed while providing the same experience in the end.

No real reason really, most of what's there is copied from the original setup. Can easily be replaced.

  1. As for the usage of a service, it's a really clever idea but I feel we need to have clear instructions on how to use it for novice Linux users (which most Steam Deck users are). Perhaps some extra notes and instructions about the fact that Peacock will run in the background indefinitely (even if it should have low to no impact on performance at idle), how to start and stop it and how to see logs should help in that regard.

Yeah I wish that ~/.config/autostart worked in gaming mode but it doesn't, only services work. Also fair point though, I'll add a little troubleshooting section at the bottom since I also realized this morning that some of the steps could fail in unclear ways (eg if someone installed steam in a dumb place and it can't find the library folders)

elken commented 10 months ago

I've made all these changes, and I'll rebase the commits in the next few days but once it's rebased it's good enough to go in (either that or you can squash-merge this PR)

Happy Christmas all :christmas_tree:

alex73630 commented 10 months ago

Sorry for the delay, I'm installing HITMAN on my Steam Deck to fully test it out but outside of that code seems good. I'll send an update once I'm done testing 👍

elken commented 10 months ago

Changes made & I've squashed the commits now :smile: