search

thephoenixlodge / Heavens-of-Sorcery

Heavens of Sorcery modpack for MC 1.12.2. Developed by thephoenixlodge for ItsLewdicolo
MIT License
12 stars 4 forks source link

Vanilla and Quark wooden chests will accept all levels of chest upgrade items from MetalChests #96

Open eSonOfAnder opened 3 years ago

eSonOfAnder commented 3 years ago

The chest upgrade items from MetalChests can be used on any base chest, including normal wooden chests, regardless of the type of upgrade.

e.g. A Copper to Obsidian Chest item used on a regular wooden chest will upgrade it to an obsidian chest.

This happens with all of the chest upgrade items.

Meowdoleon commented 3 years ago

I can't reproduce it. I tried a Diamond to Obsidian on a Gold chest, and it didn't works.

eSonOfAnder commented 3 years ago

The problem may be limited to wooden chests that all of the upgrades work on. I will do some testing in a creative test world, but the specific example I included in the original report is 100% reproducible in 0.10.0-beta. I will try to come up with a comprehensive list, but I would suggest starting with trying all of the upgrades on wooden chests first.

eSonOfAnder commented 3 years ago

The Oak Chest and the Quark variant wood type chests (Spruce, Birch, Jungle, Acacia, and Dark Oak) will all accept all levels of MetalChest upgrades, including those listed below that they should not:

The Iron, Gold, Copper, Silver, Diamond, and Obsidian chests are unaffected. The Bewitchment and Blue Skies chests do not accept the MetalChest upgrades at all, including those that are Wood to x, but that may be intentional.

I have updated the title of this bug to reflect the additional information.

Meowdoleon commented 3 years ago

I confirm that I reproduced this glitch with the oak chest.

s3ptum commented 3 years ago

Can confirm this issue can be reproduced in my personal modpack

eSonOfAnder commented 3 years ago

Oof, I worry that this mod has been abandoned; there has not been a release in over a year at this point. I just cloned the repo to see if I could figure out where the bug is, myself, but even if I submit a pull request, there's no guarantee of an updated release with a fix.

eSonOfAnder commented 3 years ago

Per the latest commit to the Metal-Chests github a month ago, the dev may be in the middle of a complete re-write from scratch as the whole repo has been nuked from space, so I can't even submit a PR with the fix (and it's a simple fix, sadly). I can supply a fixed JAR for the mod, but it's not something that can be distributed through the Twitch launcher or anything since it's not an officially published release of the mod.