Cast to bool only if Argument noValue is true

thephpleague / climate

PHP's best friend for the terminal.

http://climate.thephpleague.com

MIT License

1.87k stars 123 forks source link

Open ElGigi opened 3 years ago

duncan3dc commented 3 years ago

Hi @ElGigi, what's the purpose of this change? Does it fix some bug?

ElGigi commented 3 years ago

Sorry, description missing.

If the $noValue parameter is false, the argument is still casted to bool. But so false, it is because a value is expected.

The patch checks the value of the parameter before forcing cast.

ElGigi commented 2 years ago

Any news? Thx