Switch to singleton method for Laravel 5.2 - change works fine in Laravel 5.1 too.

[thinksaydo]

Laravel 5.2 deprecates the bindShared method in favor of the singleton method (see http://laravel.com/docs/master/upgrade).

[clslrns]

+1, this issue stops me from upgrading to 5.2.

[thinksaydo]

Switching to this method will not break Laravel 5.1 compatibility either, so it should be accepted as soon as possible now that 5.2 has been released.

[GrahamCampbell]

:+1: That method has existed to replace the old bindShared method for a long time, I think since L4.2.

[GrahamCampbell]

I finally deleted the bindShared method in 5.2, sorry guys, lol.

[thinksaydo]

Thanks @GrahamCampbell, I know it's been on the chopping block for a while. Any chance you can accept this pull request so we can get Color Extractor working in 5.2 again? Right now we're just using our fork until this gets resolved.

[mikerice]

Would definitely appreciate this getting accepted :pray: :+1:

[MatTheCat]

Is there any compatibility issue? Would this break under Laravel < 4.2?

[GrahamCampbell]

Is there any compatibility issue? Would this break under Laravel < 4.2?

Not 4.2 I think, but maybe 4.1. I can't remember.

[MatTheCat]

Seems singleton existed since laravel uses composer so it shouldn't be a problem.

[GrahamCampbell]

Seems singleton existed since laravel uses composer so it shouldn't be a problem.

Yeh, it existed, but I think it's behaviour changed a bit.

[MatTheCat]

I didn't see any difference between versions. Considering it seems unlikely to cause BC I'll merge this and see later if issues arise because of this.

Close #35

[MatTheCat]

Thanks @thinksaydo