thephpleague / color-extractor

Extract colors from an image like a human would do.
thephpleague.com
MIT License
1.3k stars 159 forks source link

Feature/drop php5 #52

Closed nyamsprod closed 5 years ago

nyamsprod commented 6 years ago

@MatTheCat This is a upgrade to the codebase which drops support of PHP5.

I've added stric types and typehint/return type everywhere I could. I've added test suite to cover and improve the Color class. Last but not least all the classes are made final.

Some of the changes are BC break but it cleans up the codebase and allow adding more feature and or improving the code more easily IMO.

I understand if this is not merge directly but it's I hope a good starting point for discussion. What do you think ?