Fix recursive register() on ServiceProviderAggregate

thephpleague / container

Small but powerful dependency injection container

http://container.thephpleague.com

MIT License

841 stars 101 forks source link

Fix recursive register() on ServiceProviderAggregate #220

Closed pcoutinho closed 3 years ago

pcoutinho commented 3 years ago

This MR aims to address issue #219 where an accidental recursive call to the register() method of the ServiceProviderAggregate was happening.

It contains 2 commits, the first being the test to prove the issue was happening and the scenario that triggered it and the second is the actual fix.

Happy to provide any more clarification if needed.

philipobenito commented 3 years ago

Sorry for the delay on this, doing some housekeeping this week so will get this merged and a release out with some other planned fixes before the next major version.

pcoutinho commented 3 years ago

Hi @philipobenito ! Doing a cheeky bump on this PR just because it's starting to block some stuff I'm developing... :sweat_smile: Would really appreciate if this could be fixed soon.

philipobenito commented 3 years ago

Sorry, work got in the way, will look to sort by this weekend