search

thephpleague / csv

CSV data manipulation made easy in PHP
https://csv.thephpleague.com
MIT License
3.34k stars 336 forks source link

New Tag for PHP 8.0 ? #404

Closed KangAdmin closed 3 years ago

KangAdmin commented 3 years ago

Feature Request

Q A
New Feature yes
BC Break yes/no

Proposal

Hello, It seems you make some change in Master branch to make it compatible with PHP 8.0, but no new tag Could you create a new tag to get it, if modification are finish ! Thank you !

nyamsprod commented 3 years ago

@KangAdmin indeed the modification are not finished as you can see the test suite is broken. But feel free to finish them any help is welcomed and will be credited in the changelog. 👍

iquito commented 3 years ago

Can a version 9.6.2 be released with the new PHP version constraint at least? Currently, if you try to use leage/csv with PHP8, it downgrades from 9.6.1 to 9.5.0. Even if this library has problems with PHP8, a downgrade to a previous version is even worse, and the new minimum version constraint PHP>=7.2.5 is an improvement over PHP^7.2 in general.