fix CI for PHP 8.0 - Githubissues

thephpleague / csv

CSV data manipulation made easy in PHP

https://csv.thephpleague.com

MIT License

3.34k stars 336 forks source link

fix CI for PHP 8.0 #405

Closed IonBazan closed 3 years ago

IonBazan commented 3 years ago

Fixes #404 - iterator_to_array is not marked as pure anymore: https://github.com/JetBrains/phpstorm-stubs/pull/969 Checks are still run on PHP 7.4 because PHP 8.0 introduces false return type for createElement and other DOM-related methods - I will try to provide a fix in a separate PR soon.

nyamsprod commented 3 years ago

@IonBazan thanks for the PR will review and merge it as soon as possible 🎉 and I will credit you for making the package available for PHP8 in the changelog 👍

IonBazan commented 3 years ago

@nyamsprod Thank you for merging. Can you also create a new release to allow users to migrate to PHP 8.0?

nyamsprod commented 3 years ago

@IonBazan it's in my today's to-do list don't worry 😉