thephpleague / csv

CSV data manipulation made easy in PHP

https://csv.thephpleague.com

MIT License

3.34k stars 336 forks source link

Improve PHPUnit assertion and fixtures #415

Closed peter279k closed 3 years ago

peter279k commented 3 years ago

Changed log

Using the assertContains to assert expected contains the specific key.
According to the official PHPUnit doc, it should be protected function setUp and protected function tearDown methods.

nyamsprod commented 3 years ago

@peter279k your fix is not passing the coding style check in PHP8.0. You need to remove thhe useless use in_array declaration. After which I'll merge the PR

peter279k commented 3 years ago

Fixed :).