search

thephpleague / csv

CSV data manipulation made easy in PHP
https://csv.thephpleague.com
MIT License
3.33k stars 333 forks source link

Minor fixes #456

Closed george-zakharov closed 2 years ago

george-zakharov commented 2 years ago

Hi!

I've made some minor style fixes. Regards

nyamsprod commented 2 years ago

@george-zakharov I like the typo fixes but I am a bit against the coding style changes you added in the PR. Those coding style exists since v9 and even if I want to change some I will probably update them for v10 whenever that one comes alive but not before to stay as consistent as possible. If you could update your PR and only submit the typo changes I would gladly merge them ASAP

george-zakharov commented 2 years ago

Okay, I'll fix it :)

george-zakharov commented 2 years ago

@nyamsprod did it :)

nyamsprod commented 2 years ago

@george-zakharov thanks. By the way now that I saw your answer I get it. League CSV uses PSR-2 as the basis of it's coding style + some additions by me. It was done prior to PSR-12 or PSR-2R was even created This explain more my why's 😉 . Anyway I will review the package coding style when the next major version is released. Thanks for the PR in any case.

george-zakharov commented 2 years ago

@nyamsprod thank you too! I will try to contribute further :)